-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LAST_MODIFIED attribute when exporting #860
Conversation
What would be the benefit of adding this? |
Trying to reserve all original info. |
Preserving information is not really a benefit in itself, unless it supports some other feature. The modified date isn't really used anywhere in the app, which is why I'm asking. |
As far as I'm concerned, it's helpful to me because I don't want to lose such infomation when I migrate bookmarks between browser and linkding. Besides, if someone need to sort by modified date in linkding, that would be helpful too, although one can only sort by added date and title at the moment. |
@sissbruecker |
I saw that One thing that's missing from this PR is tests, would be good if you could add those. |
…e parsed datetime.
6a942d4
to
1b5cce6
Compare
Exactly that is supported by firefox and edge which I'm using, And that's why I made this PR.
I try hard to add tests. When doing that, I find it's hard to split into two PR, and so, I merge "parse-LAST_MODIFIED" PR into this one. Please review. |
Thanks! |
No description provided.