Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LAST_MODIFIED attribute when exporting #860

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

ixzhao
Copy link
Contributor

@ixzhao ixzhao commented Sep 27, 2024

No description provided.

@sissbruecker
Copy link
Owner

What would be the benefit of adding this?

@ixzhao
Copy link
Contributor Author

ixzhao commented Sep 29, 2024

What would be the benefit of adding this?

Trying to reserve all original info.
When I export or import bookmarks in my browser or linkding, last modified info gets lost.

@sissbruecker
Copy link
Owner

Preserving information is not really a benefit in itself, unless it supports some other feature. The modified date isn't really used anywhere in the app, which is why I'm asking.

@ixzhao
Copy link
Contributor Author

ixzhao commented Sep 29, 2024

Preserving information is not really a benefit in itself, unless it supports some other feature. The modified date isn't really used anywhere in the app, which is why I'm asking.

As far as I'm concerned, it's helpful to me because I don't want to lose such infomation when I migrate bookmarks between browser and linkding. Besides, if someone need to sort by modified date in linkding, that would be helpful too, although one can only sort by added date and title at the moment.

@ixzhao
Copy link
Contributor Author

ixzhao commented Oct 2, 2024

@sissbruecker
Would you consider this, or should I close the PR?

@sissbruecker
Copy link
Owner

I saw that LAST_MODIFIED is something that's also supported by browsers, with that I'm fine with adding it.

One thing that's missing from this PR is tests, would be good if you could add those.

@ixzhao
Copy link
Contributor Author

ixzhao commented Oct 2, 2024

I saw that LAST_MODIFIED is something that's also supported by browsers, with that I'm fine with adding it.

Exactly that is supported by firefox and edge which I'm using, And that's why I made this PR.

One thing that's missing from this PR is tests, would be good if you could add those.

I try hard to add tests. When doing that, I find it's hard to split into two PR, and so, I merge "parse-LAST_MODIFIED" PR into this one. Please review.

@sissbruecker sissbruecker changed the title add LAST_MODIFIED attribute when exporting Add LAST_MODIFIED attribute when exporting Oct 2, 2024
@sissbruecker sissbruecker merged commit 1f2cf21 into sissbruecker:master Oct 2, 2024
2 checks passed
@sissbruecker
Copy link
Owner

Thanks!

@ixzhao ixzhao deleted the export-LAST_MODIFIED branch October 2, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants