-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE Inspector link value object property #44
base: main
Are you sure you want to change the base?
Conversation
With neos/flow-development-collection#2762 native support for vo's in various places was introduced. Also in node property values where the neos ui uses the `DenormalizingObjectConverter` to convert the serialized data to the object. Unfortunately the reverse currently does NOT use the expected `\JsonSerializable::jsonSerialize` but rather asks the `ArrayFromObjectConverter` for object types when serializing properties for the ui. That leads to the need of aop like here https://github.com/sitegeist/Sitegeist.InspectorGadget/blob/78f5f4a206287b1c4bedf5cb88582ed51cb4a311/Classes/Infrastructure/NodeInfo/NodeInfoPostProcessingAspect.php#L17 This bugfix will make use of the `\JsonSerializable` interface instead directly when serializing properties for the neos ui.
Sounds really good. But just to be clear: This does not affect the existing editor and its output, right? |
Yes exactly. This feature is only available for the (Im thinking about allowing fragments also for strings (if enabled) as it would be possible to encode this into the uri (obviously)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally very much like this and it looks fine by 👀 .
Much cleaner to specify a type: link
than to say a string with a link editor.
yep, works |
This feature introduces a php link value object which can also be used as node property with editor support.
Advanced Inspector Editor Configuration with
Sitegeist\Archaeopteryx\Link
value object type:As the value object can serialize more than just the
href
we can also edit other link related options liketitle
and thetarget
.The link value object can be queried as usual. An example rendering would look the following:
To try this feature out already, require this dev branch in your composer root:
Demo Video:
Bildschirmaufnahme.2023-10-23.um.20.25.50.mov