FEATURE: Add Ctrl+k keyboard shortcut handler #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradinarufelix
force-pushed
the
feature-keyboard-shortcut
branch
2 times, most recently
from
9a7cf4d to
3bcf37f
Compare
Benjamin-K
reviewed
Oct 4, 2024
| } | ||
|
|
||
| const ckeditor5Configuration = ckeditor5Registry.get<SynchronousRegistry<any>>('config') | ||
| if (!ckeditor5Registry) { |
There was a problem hiding this comment.
This should be ckeditor5Configuration, or not?
|
|
||
| ckeditor5Configuration.set('keystrokes', (ckEditorConfiguration: { plugins: ((ckEditorInstance: NeosEditor) => void)[]; }) => { | ||
| ckEditorConfiguration.plugins.push((ckEditorInstance) => { | ||
| ckEditorInstance.keystrokes.set('Ctrl+k', async (_: any, cancel: () => void) => { |
There was a problem hiding this comment.
Is it easily possible to make the shortcut configurable in a configuration file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds #62. The old link editor could be opened by pressing
Ctrl+k. One of our customer's editors was missing that possibility.I added another package with a keyboard shortcut handler, which follows the logic of the
LinkButton.Possible improvements could be to streamline and de-duplicate the code from
LinkButtonand the keyboard shortcut handler.