Skip to content

Commit

Permalink
BUG: fix dimensionInformatonViewHelper
Browse files Browse the repository at this point in the history
The render method should be declared without arguments according to the fluid core view helpers. This causes an issue while determining the root node what could potentially lead to a wrong behavior
  • Loading branch information
davidspiola committed Nov 24, 2020
1 parent d134170 commit dda0972
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions Classes/ViewHelpers/DimensionInformationViewHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,15 @@ public function initializeArguments()
}

/**
* @param NodeInterface $node
* @param string $dimension dimension name
* @return string value with replaced text
* @api
*/
public function render(NodeInterface $node, $dimension = null)
public function render()
{
return self::renderStatic(
[
'node' => $node,
'dimension' => $dimension
'node' => $this->arguments['node'],
'dimension' => $this->arguments['dimension']
],
$this->buildRenderChildrenClosure(),
$this->renderingContext
Expand Down

0 comments on commit dda0972

Please sign in to comment.