feat: Gfranxman/345 ensure latest version of rsync #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for dependencies In this commit, the shell interpreter from sh has been changed to bash. The install script now also includes a version checking mechanism for dependencies. This ensures that the required versions of dependencies are installed. The install script also includes comments detailing its purpose and usage. The shell command in the GitHub workflow and README installation instructions have been updated accordingly. Debug log messages have been added for troubleshooting purposes.
Change the 'return 1' statement to 'exit 1'. This modification ensures the script terminates if the top level dependencies are not met.
Update curl, make, python3, rsync to not just install these packages, but to upgrade them if they're already installed. Ensure that the latest version of these packages are used by adding upgrade commands to the installation instructions for different operating systems. Update Ubuntu/Debian instruction to include package list update before installation.
Add commands in setup project YAML to update and upgrade curl. Include commands to update and upgrade `make`. Insert commands to update and upgrade Python3.
- Reduce the minimum required version of curl from 8.6 to 7.80 - Reduce the minimum required version of make from 4.4 to 4.3 - Reduce the minimum required version of python3 from 3.11 to 3.10 In order to satisfy ubuntu-latest after upgrading these three packages, had to back off a bit to require what's available.
- Change setup-project script to enhance debugging. - Comment out curl command for obtaining installation script. - Add DEBUG=True before calling install.sh script.
command Modify the setup-project.yaml workflow. Replace the direct execution of the install.sh script with a curl command. This change aims to improve script download and installation process for the scaf tool.
The minimum version for bash dependency has been lowered from 5.2 to 5.1 in our install.sh script.
- Update the success message when all top-level dependencies are installed and meet the required version. - The message now includes celebration emoji for a bit of fun and visual feedback.
- Refactor the installation script to use `/bin/sh` instead of `/bin/bash` - Change the format of the `dependencies` variable to include versions - Adjust the version checking code to handle different version formatting more appropriately - Revise dependency-checking output messages for clarity, moving them to individual lines - Modify some error messages to better indicate the issue - Fix some miscellaneous style issues.
gfranxman
changed the title
Reducing the required curl version from 8.7.0 to 7.8.0 in the dependencies.
| INSTALL_URL="https://raw.githubusercontent.com/sixfeetup/scaf/$GITHUB_REF_NAME/install.sh" | ||
| export SCAF_SCRIPT_BRANCH=$GITHUB_REF_NAME | ||
| git config --global init.defaultBranch main | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "CI CD install deps" | ||
| echo "Downloading install script from $INSTALL_URL" | ||
| rm -f $HOME/.local/bin/scaf | ||
| curl -sSL $INSTALL_URL | sh | ||
| echo "Installing scaf from $INSTALL_URL" | ||
| curl -sSL $INSTALL_URL | DEBUG=True bash |
There was a problem hiding this comment.
GitHub actions are tripping up on this change since scaf is not being installed.
- Enhanced temporary directory creation with a unique name. - Simplified dependency checks by removing unnecessary exit and conditionals. - Fixed file moving logic to ensure proper destination handling without redundant path. - Improved debug logging for better tracking of installation steps.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
## [1.18.0](v1.17.2...v1.18.0) (2024-11-01) ### Features * Gfranxman/345 ensure latest version of rsync ([#400](#400)) ([8dbc784](8dbc784))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.