feat: Add k3s as option for kubernetes install #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licquia
approved these changes
Dec 11, 2024
| desc: | | ||
| Enable the ECR credential helper on all control plane nodes. | ||
| cmds: | ||
| - echo "TODO" |
There was a problem hiding this comment.
:-)
We should at minimum file a ticket to ensure this doesn't get missed.
There was a problem hiding this comment.
Absolutely! I planned to add this to the PR and ask for another review before I merge.
There was a problem hiding this comment.
@licquia ecr credential helper added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds k3s as an option for the Kubernetes install.