Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial support for task vars #30

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

fgiorgetti
Copy link
Member

  • Some roles and modules were not expecting variables as part of task_vars
  • Modules now have mechanisms to read arguments from both host and task

* Some roles and modules were not expecting variables as part of task_vars
* Modules now have mechanisms to read arguments from both host and task
@fgiorgetti
Copy link
Member Author

Please ignore changes done to, as they are just auto-generated content:
docs/
skupper/network/docs/
skupper/network/tests/output/

@fgiorgetti fgiorgetti self-assigned this Feb 19, 2024
@fgiorgetti
Copy link
Member Author

@granzoto @ajssmith I am going to merge this one as it won't be released right now.
Later once we aim to release an eventual udpate to 1.2.x, I will request a new round of review.

Once this lands, I will push the changes related to the new collection name.

@fgiorgetti fgiorgetti merged commit ff97635 into skupperproject:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant