Proper handling of job removal on TestGateway subtests (#1462)

Moved job deletion to a defer() call, to ensure it is executed in case of errors.
skupperproject · May 2, 2024 · 1acf74f · 1acf74f
1 parent 6fb3a1d
commit 1acf74f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/test/integration/acceptance/gateway_test.go b/test/integration/acceptance/gateway_test.go
@@ -156,16 +156,14 @@ func testServices(t *testing.T) {
 		if err != nil {
 			return err
 		}
+		defer cluster.VanClient.KubeClient.BatchV1().Jobs(cluster.Namespace).Delete(context.TODO(), job.Name, v12.DeleteOptions{})
+
 		_, err = k8s.WaitForJob(cluster.Namespace, cluster.VanClient.KubeClient, name, time.Minute)
 		if err != nil {
 			_, _ = cluster.KubectlExec("logs job/" + name)
 			testRunner.DumpTestInfo(name)
 			return err
 		}
-		err = cluster.VanClient.KubeClient.BatchV1().Jobs(cluster.Namespace).Delete(context.TODO(), job.Name, v12.DeleteOptions{})
-		if err != nil {
-			return err
-		}
 		return nil
 	}