Initial implementation of skupper diagnose #1803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Stephen. We are using "skupper debug" as the place to collect all debugging and troubleshooting operations. I think this operation should live there as well. Based on what it's doing, I propose "skupper debug check" as the command name. I also see that the top level "diagnose" requires a "--kube" to run all the checks. I think it should instead use the current platform (determined by --platform or SKUPPER_PLATFORM), and thus run all the checks without the extra arg. As a naming thing, I propose using kube instead of k8s for the short form, since we are already using kube in other places. |
skitt
force-pushed
the
diagnose-v2
branch
3 times, most recently
from
bee49ee to
69dd3ca
Compare
This introduces a framework for diagnostics commands, with an initial implementation of two Kubernetes checks (verifying that the Kubernetes API is accessible, and that the Kubernetes version is supported). The framework supports simple declaration of Cobra commands constructed from individual diagnostics, and dependencies between diagnostics. The kind spinner is copied with some adaptations borrowed from the Submariner project. Signed-off-by: Stephen Kitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a framework for diagnostics commands, with an initial implementation of two Kubernetes checks (verifying that the Kubernetes API is accessible, and that the Kubernetes version is supported).
The framework supports simple declaration of Cobra commands constructed from individual diagnostics, and dependencies between diagnostics.
The kind spinner is copied with some adaptations borrowed from the Submariner project.