Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CX 0.7.1 #26

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

CX 0.7.1 #26

wants to merge 8 commits into from

Conversation

BigOokie
Copy link
Contributor

Fixes #25

Changes:

  • Update Skycoin-cx formular for release v0.7.1
  • Updated Readme to document alternate process for testing formulas.

Does this change need to mentioned in CHANGELOG.md?

Yes - Included in PR

@BigOokie
Copy link
Contributor Author

@olemis I have just raised this PR. I have tested it out of my development repo - based on the new process i documented in the readme. Once Travis has completed, assuming no issues, could you please review

@BigOokie
Copy link
Contributor Author

@olemis appears the Travis build failed - but not certain its related to the changed I made.

Errors appear to be related to installing various packaged in Travis:

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
...
An error occurred while installing nokogiri (1.10.3), and Bundler
...
Error: failed to run /Users/travis/.gem/ruby/2.3.0/bin/bundle install! The command "brew audit $(brew --repo $TRAVIS_REPO_SLUG)/Formula/*.rb" exited with 1.

The below relates to the Skycoin-cx v0.7.1 changes - which appear to have been successful

8.98s$ brew install skycoin-cx
==> Installing skycoin-cx from skycoin/skycoin
==> Downloading https://github.com/skycoin/cx/releases/download/v0.7.1/cx-0.7.1-
==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws
######################################################################## 100.0%
🍺  /usr/local/Cellar/skycoin-cx/0.7.1: 3 files, 20.6MB, built in 5 seconds
Removing: /Users/travis/Library/Caches/Homebrew/skycoin-cx--0.7.0.zip... (12.6MB)
The command "brew install skycoin-cx" exited with 0.
1.19s$ brew unlink skycoin-cx
Unlinking /usr/local/Cellar/skycoin-cx/0.7.1... 1 symlinks removed
The command "brew unlink skycoin-cx" exited with 0.

Any ideas?

@BigOokie
Copy link
Contributor Author

@olemis looks like its worked now. Travis is happy ;)

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@BigOokie
Copy link
Contributor Author

@olemis could you review again when you get a chance - thx.

@BigOokie
Copy link
Contributor Author

@olemis could you review this one. I expect it should be good to go

@BigOokie BigOokie requested a review from olemis September 19, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update skycoin-cx formula for release 0.7.1
2 participants