Skip to content

Commit

Permalink
docs: specify endpoint_allowed_accounts clearly (#29)
Browse files Browse the repository at this point in the history
  • Loading branch information
vasiliyskysql authored Nov 14, 2024
1 parent 51c4584 commit 2df4485
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/resources/service.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ resource "skysql_service" "default" {
- `architecture` (String) The architecture of the service. Valid values are: amd64 or arm64
- `availability_zone` (String) The availability zone of the service
- `deletion_protection` (Boolean) Whether to enable deletion protection. Valid values are: true or false. Default is true
- `endpoint_allowed_accounts` (List of String) The list of cloud accounts (aws account ids or gcp projects) that are allowed to access the service
- `endpoint_allowed_accounts` (List of String) The list of cloud accounts (aws, azure, or gcp projects) that are allowed to access the service. Works only with `privateconnect` endpoint mechanism
- `endpoint_mechanism` (String) The endpoint mechanism to use. Valid values are: privateconnect or nlb
- `is_active` (Boolean) Whether the service is active
- `maxscale_nodes` (Number) The number of MaxScale nodes
Expand Down
2 changes: 1 addition & 1 deletion examples/azure-private-link/locals.tf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
locals {
dns_domain = join(".", [var.skysql_organization_id, var.skysql_base_domain])
dns_domain = join(".", [var.skysql_organization_id, var.skysql_base_domain])
dns_link_name = join(".", [var.skysql_organization_id, replace(var.skysql_base_domain, ".", "-")])
}
4 changes: 2 additions & 2 deletions examples/azure-private-link/main.tf
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
data "azurerm_subscription" "current" {}

data "azurerm_resource_group" "this" {
name = var.resource_group_name
name = var.resource_group_name
depends_on = [azurerm_resource_group.this]
}

Expand Down Expand Up @@ -36,7 +36,7 @@ resource "skysql_service" "this" {
}

resource "azurerm_resource_group" "this" {
count = var.create_resource_group ? 1 : 0
count = var.create_resource_group ? 1 : 0
name = var.resource_group_name
location = var.location
}
Expand Down
2 changes: 1 addition & 1 deletion examples/azure-private-link/variables.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
variable "location" {
description = "The Azure Region in which all resources will be created."
type = string
type = string
default = "eastus"
}

Expand Down
2 changes: 1 addition & 1 deletion internal/provider/service_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ var serviceResourceSchemaV0 = schema.Schema{
"endpoint_allowed_accounts": schema.ListAttribute{
Optional: true,
Computed: true,
Description: "The list of cloud accounts (aws account ids or gcp projects) that are allowed to access the service",
Description: "The list of cloud accounts (aws, azure, or gcp projects) that are allowed to access the service. Works only with `privateconnect` endpoint mechanism",
ElementType: types.StringType,
Default: listdefault.StaticValue(types.ListNull(types.StringType)),
},
Expand Down

0 comments on commit 2df4485

Please sign in to comment.