Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smallrye.jwt.verify.secretkey property for inlining secret keys #815

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

sberyozkin
Copy link
Contributor

@sberyozkin sberyozkin commented Aug 15, 2024

It will make it possible to use env vars to pass the signing secret key information, as asked for in quarkusio/quarkus#42550.

In fact, passing the secret key content using the public key property also works but it is not great asking users to use that property

@sberyozkin sberyozkin added this to the 4.5.4 milestone Aug 15, 2024
MikeEdgar
MikeEdgar previously approved these changes Aug 15, 2024
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question and a minor suggestion.

@sberyozkin sberyozkin merged commit d4c2714 into smallrye:main Aug 15, 2024
7 checks passed
@sberyozkin sberyozkin deleted the inlined_jwk_key branch August 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants