Allow to build JWT from JSON string #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
previously approved these changes
Aug 20, 2024
implementation/jwt-build/src/main/java/io/smallrye/jwt/build/Jwt.java
Outdated
Show resolved
Hide resolved
implementation/jwt-build/src/main/java/io/smallrye/jwt/build/Jwt.java
Outdated
Show resolved
Hide resolved
implementation/jwt-build/src/main/java/io/smallrye/jwt/build/Jwt.java
Outdated
Show resolved
Hide resolved
sberyozkin
force-pushed
the
claims_json
branch
from
bc809b2 to
5addb0a
Compare
|
Thanks @MikeEdgar, I'll do a minor follow up PR to fix those doc typos in all other similar comments :-) |
MikeEdgar
approved these changes
Aug 20, 2024
Thanks @sberyozkin, no big deal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #813.
This PR adds another method to the JWT builder API to simplify signing JSON strings.
For example, I've that often enough, in a test I have a JSON string ready (or it may be coming from DB) but we only have
Jwt.claims(Map),Jwt.claims(JsonObject)andJwt.claims(String jsonFileLocation)start options - so I have to convert JSON String to JsonObject myself, which is not great.