Add jwksRetainOnErrorDuration #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sberyozkin |
|
Hi @luneo7, thanks, believe it or not, I started typing something as well, trying to fix it, but I'm glad you've done it faster as I was just thinking, how exactly am I going to test it... Thanks |
sberyozkin
reviewed
Nov 15, 2024
implementation/jwt-auth/src/main/java/io/smallrye/jwt/config/JWTAuthContextInfoProvider.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Nov 15, 2024
implementation/jwt-auth/src/main/java/io/smallrye/jwt/config/JWTAuthContextInfoProvider.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Nov 15, 2024
implementation/jwt-auth/src/main/java/io/smallrye/jwt/config/JWTAuthContextInfoProvider.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Nov 15, 2024
...ation/jwt-auth/src/main/java/io/smallrye/jwt/auth/principal/AbstractKeyLocationResolver.java
Outdated
Show resolved
Hide resolved
|
@luneo7 LGTM overall, thanks very much, minor suggestions are proposed, and please follow up later with a standalone dedicated PR, enjoy the weekend |
|
Forgot one thing - please add a new property description in the config docs - probably next to the JWK refresh interval property |
|
@sberyozkin done the requested changes =) |
sberyozkin
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds jwksRetainOnErrorDuration so we can also support Jose4J
setRetainCacheOnErrorDurationand keep the current for a time period, before trying to fetch the cache again, if some error happens during cache refresh.Handles #826