-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all dependencies #186
base: master
Are you sure you want to change the base?
Conversation
- updated dependencies - fixed compilation warnings and errors on client
- fixed errors on the logging page in the browser and - fixed logout - fixed languages
Check the browser developer tools to see whether the URL to the CSS files is correct (you don't want to see If this doesn't help, I will try to install it on my machine and check. Btw, there is no need to close and create a new pull request, you can just push to the |
- problem with settings sidebar
- dubious ownership is because of chown in functions
- dealing with cors
- little bit improved styles - fixed edit shown two times (and other problems with menu) - removed types because of elastic search versions - repaired bugs with modals (not possible to close, setting state of unmounted..) In process: Validation of any form fails when the values were not changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahoj Davide, zběžně jsem prošel tvoje změny a narazil na pár drobností, kde si myslím, že by to chtělo trošku upravit. Někde jsi smazal části, které si myslím, že by měly zůstat zachované, ale to se vůbec nedivím, vzhledem k velikosti projektu vůbec je těžké všimnout si všeho. Díky.
- renamed withTranslationCustom to withTranslation, resolved conflict - removed cors artifacts - returned trusted/sandbox tag todo - if in modals - interval x fixed_interval in elasticsearch-query
- renamed withTranslationCustom to withTranslation, resolved conflict - removed cors artifacts - returned trusted/sandbox tag - return if in modals - changed fixed_interval to interval for number data in elasticsearch-query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahoj Davide, povedlo se mi projít další část tvých změn. Narazil jsem tam na pár věcí, které ještě nejsou dodělané (zůstaly zakomentované). Většina z toho se týká routeru, tak jsem tě chtěl poprosit, jestli bys na to ještě mrknul, přeci jenom máš s tou novou verzí routeru trochu víc zkušeností, když už jsi nějaké úpravy dělal. Ale pokud vůbec netušíš, co s tím, tak to můžeme prostě sepsat do toho TODO v popisu pull requestu a pak nějak postupně vyřešit (já jsem mezitím některé z těch TODO vyřešil). Tak jen dej vědět, jestli se do těch dodělávek budeš pouštět nebo ne (třeba jako odpovědi na ty příslušné komentáře). Každopádně prioritu má tvorba docker kontejneru pro instalaci a základní verze API pro ExtremeXP, tohle klidně nech až potom. Díky.
- Added scripts setup/create_indexes.sh and executed-workflows-test.sh
This reverts commit 99674ba.
The Docker files are a modified version from the ExpVis wrapper.
TODO:
form-group
withmb-3
mb-3
(margin bottom) from Bootstrap instead of customwithPadding
setFlashMessage
method refreshes the pagecreateChartZoom()
method inTimeBasedChartBase
http://localhost:8080/workspaces/sample2
, it should redirect me to the login page (http://localhost:8080/login?next=%2Fworkspaces%2Fsample2
). Right now, it just crashes.page.js
)SubRoute
for the new routerSection
,SectionContent
andRenderRoute
components inpage.js
, because of changes in react-router@v6 (theuseBlocker
hook requires data API router which has a different schema for specifying the routes).console.log
sThis is not a new error (it was in the older version), but I just wanted to note it somewhere: