Make backtrace cleaning optional #328
Conversation
|
Before fixing the failing test for https://travis-ci.org/smartinez87/exception_notification/builds/112021045, I'd like that we address the questions in my PR ! Thanks ! |
Updated README for Slack notifier
…-recipients Allow exception_recipients to be a proc
|
hi @vala, thanks for this. Maybe we can go with writing a separate test class to test the exception with a controller exception for now, to have the feature available. |
|
Can you also please add an entry to the changelog with this, mentioning you and @chancancode as the authors? |
Fix the url of HipChat repo
This, I think, is the most common use-case for custom data, and I think many people will benefit from a simple example. [ci skip]
…ustom_data A simpler example of custom data
…eption_notification into optional_backtrace_cleaning
|
Hello. This has been open for over a year. Anything I can do to help get it merged? cc @vala @smartinez87 |
|
If you want to take the PR over don't hesitate, I'm unsure I'll be able to work on that soon. Sorry for the lack of follow-up on this |
|
@monfresh Would you mind taking care of this PR if it's still a desired feature for you. Otherwise, I'll try to move this forward. Thank you |
|
I discovered this PR while looking for any existing issue or PR for adding backtrace cleaning for So I am glad to find this PR makes both notifications clean backtraces and hope it gets merged soon. |
This is a new take of the previous #242 pull request by @chancancode.
I borrowed the tests and adapted the implementation he wrote at the time to work with the current gem's code.
But, to make the tests pass, I had to add the ability to clean the backtracke to the
#background_exception_notificationsince the EmailNotifier tests are written with the background notification.This seems bad to me, since we wouldn't have the ability to disable backtrace cleaning only for the controller-exception backed email notifier.
Which way should I go ? Write a separate test class to test the exception with a controller exception ?
This brings be to think about the whole backtrace cleaning strategy, is it really useful ? Can't we just, in the HTML e-mail, differenciate app and gem backtrace lines ?
Thanks for your feedback !