fix: fix invalid voting delay when set from space (#1020)

* fix: fix invalid voting delay when set from space * refactor: set proposal start and end time only in Editor
snapshot-labs · Dec 5, 2024 · 8c28fad · 8c28fad
1 parent 12af42f
commit 8c28fad
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 2 deletions.
diff --git a/apps/ui/src/composables/useActions.ts b/apps/ui/src/composables/useActions.ts
@@ -286,6 +286,7 @@ export function useActions() {
     choices: string[],
     labels: string[],
     app: string,
+    created: number,
     start: number,
     min_end: number,
     max_end: number,
@@ -312,6 +313,7 @@ export function useActions() {
         choices,
         labels,
         app,
+        created,
         start,
         min_end,
         max_end,

diff --git a/apps/ui/src/networks/evm/actions.ts b/apps/ui/src/networks/evm/actions.ts
@@ -210,6 +210,7 @@ export function createActions(
       choices: string[],
       labels: string[],
       app: string,
+      created: number,
       start: number,
       min_end: number,
       max_end: number,

diff --git a/apps/ui/src/networks/offchain/actions.ts b/apps/ui/src/networks/offchain/actions.ts
@@ -131,13 +131,13 @@ export function createActions(
       choices: string[],
       labels: string[],
       app: string,
+      created: number,
       start: number,
       min_end: number,
       max_end: number,
       executions: ExecutionInfo[]
     ) {
       const provider = getProvider(space.snapshot_chain_id as number);
-
       const plugins = await getPlugins(executions);
 
       const data = {
@@ -153,7 +153,7 @@ export function createActions(
         snapshot: (await provider.getBlockNumber()) - EDITOR_SNAPSHOT_OFFSET,
         plugins: JSON.stringify(plugins),
         app: app || EDITOR_APP_NAME,
-        timestamp: Math.floor(Date.now() / 1000)
+        timestamp: created
       };
 
       return client.propose({ signer: web3.getSigner(), data });

diff --git a/apps/ui/src/networks/starknet/actions.ts b/apps/ui/src/networks/starknet/actions.ts
@@ -229,6 +229,7 @@ export function createActions(
       choices: string[],
       labels: string[],
       app: string,
+      created: number,
       start: number,
       min_end: number,
       max_end: number,

diff --git a/apps/ui/src/networks/types.ts b/apps/ui/src/networks/types.ts
@@ -142,6 +142,7 @@ export type ReadOnlyNetworkActions = {
     choices: string[],
     labels: string[],
     app: string,
+    created: number,
     start: number,
     min_end: number,
     max_end: number,

diff --git a/apps/ui/src/views/Space/Editor.vue b/apps/ui/src/views/Space/Editor.vue
@@ -228,6 +228,7 @@ async function handleProposeClick() {
         choices,
         proposal.value.labels,
         appName.length <= 128 ? appName : '',
+        currentTime,
         start,
         minEnd,
         maxEnd,