Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always allow admins and moderators to propose #1007

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Nov 29, 2024

Summary

This PR fix an issue where admins and moderators couldn't create proposal by default.

Before: admins and moderators are considered like any other proposer, and have to pass the proposal validation (and hold some VP)

after: admins and moderators can always create proposals, regardless of any space settings

How to test

  1. Go to http://localhost:8080/#/s:test.wa0x6e.eth/create
  2. Connect as regular member 0xab54624a67e8c018a06b176baae76a40a385a464 account using https://impersonator.xyz/
  3. You should see a message about insufficient voting power to create a proposal
  4. Connect as a moderator 0x757a20e145435b5bdaf0e274987653aecd47cf37
  5. You should not see any warning message, and the publish button should be enabled

@wa0x6e wa0x6e requested a review from ChaituVR November 29, 2024 15:55
@wa0x6e wa0x6e marked this pull request as ready for review November 29, 2024 15:55
@wa0x6e wa0x6e requested a review from Sekhmet November 30, 2024 03:12
@ChaituVR ChaituVR self-requested a review November 30, 2024 14:31
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Nov 30, 2024

Still not very fond of having that kind of logic inside a store, but will make do with it, until #939

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit 84094bc into master Dec 1, 2024
5 checks passed
@wa0x6e wa0x6e deleted the fix-allow-members-to-create-proposals branch December 1, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants