Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show the v2 welcome message also on landing page #1043

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: show the v2 welcome message also on landing page #1043

merged 1 commit into from
Dec 11, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Dec 11, 2024 •
edited
Loading

Summary

Closes: #1028 (comment)

This PR will also show the v2 welcome flash message on landing page

How to test

  1. clear your local storage
  2. Go to landing page
  3. You should see the v2 welcome message

@wa0x6e wa0x6e marked this pull request as ready for review December 11, 2024 03:20
ChaituVR
ChaituVR approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit e2f76cc into master Dec 11, 2024
4 checks passed
@wa0x6e wa0x6e deleted the show-v2-flash-message-on-landing branch December 11, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR