Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate resolver address before setting snapshot text record #1067

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

ChaituVR
Copy link
Member

Summary

  • Gets and validated ENS resolver before settings snapshot text record

How to test

  1. Go to http://127.0.0.1:8080/#/s:odos.eth/settings/controller
  2. Login with resolver address 0x47E2D28169738039755586743E2dfCF3bd643f86 using Safe's wallet connect
Untitled 6
  1. Change controller to some other address in space settings
  2. Transaction on safe should display new resolver address
Before After
Untitled 8 Untitled 9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

apps/ui/src/helpers/ens.ts:121

  • [nitpick] The error message 'Unsupported resolver' is unclear. Consider changing it to 'The resolver address is not supported. Please use a valid resolver address.'
throw new Error('Unsupported resolver');
@ChaituVR ChaituVR self-assigned this Dec 20, 2024
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ChaituVR ChaituVR merged commit 8fe6df6 into master Dec 21, 2024
2 checks passed
@ChaituVR ChaituVR deleted the fix-get-ens-resolver branch December 21, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants