Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get ABI method not working #1068

Merged
merged 2 commits into from
Dec 25, 2024
Merged

fix: get ABI method not working #1068

merged 2 commits into from
Dec 25, 2024

Conversation

ChaituVR
Copy link
Member

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/345

  • getABI not working because of multiple reasons (wrong URL and no API KEY)
  • Also can fetch proxy contract's ABI now

How to test

Or

@ChaituVR ChaituVR requested a review from bonustrack December 24, 2024 18:20
bonustrack
bonustrack reviewed Dec 25, 2024
View reviewed changes
apps/ui/.env Outdated Show resolved Hide resolved
bonustrack
bonustrack approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@ChaituVR ChaituVR merged commit c0e2837 into master Dec 25, 2024
2 checks passed
@ChaituVR ChaituVR deleted the fix-get-abi branch December 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @bonustrack