Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use null as snapshot for EVM spaces #806

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Sep 23, 2024

Summary

I don't remember exactly why, but for EVM we don't support null as block (issue to investigate it: #805).

But we did use null for pending proposals. This PR prevents it.

How to test

  1. You see your VP here: http://localhost:8080/#/sep:0xb58B05A1c8263441Bd74454544fD66CE25D300AD/proposal/61

@Sekhmet Sekhmet requested a review from wa0x6e September 23, 2024 14:10
Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: ab0b784

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@Sekhmet Sekhmet merged commit db5b6d7 into master Sep 23, 2024
3 checks passed
@Sekhmet Sekhmet deleted the sekhmet/default-snapshot branch September 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants