Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create dedicated composable for proposing power #988

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Nov 24, 2024

Summary

Toward #939

This PR extracts the proposition power from the useVotingPower into its own composable, and avoid mixing voting and proposing power.

Merging this one first will allow #938 to use the final correct name, without filename collision

How to test

  1. Everything should work as before
  2. Create a proposal on a space you have proposition power, you should be able to create a proposal
  3. Create a proposal on a space you do not have proposition power, it should show a message about insufficient proposition power.

@wa0x6e wa0x6e changed the title refactor: extract proposing power into its own composable refactor: create dedicated composable for proposing power Nov 24, 2024
@wa0x6e wa0x6e requested a review from Sekhmet November 24, 2024 14:56
@wa0x6e wa0x6e marked this pull request as ready for review November 24, 2024 14:56
@wa0x6e wa0x6e force-pushed the refactor-proposition-power-composable branch from 6070c05 to 5e534a0 Compare November 24, 2024 14:58
@wa0x6e wa0x6e requested a review from Sekhmet November 26, 2024 06:48
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@wa0x6e wa0x6e merged commit 6a8b3ed into master Nov 28, 2024
5 checks passed
@wa0x6e wa0x6e deleted the refactor-proposition-power-composable branch November 28, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants