auto detect inverter modules that support both position 1&2 #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dieser doch etwas größere Umbau kommt erst nach dem nächsten stabilen Release rein, um eventuelle Nebenwirkungen zu vermeiden. |
yankee42
force-pushed
the
refactor-inverter-module-call
branch
from
cea1428 to
2626dd6
Compare
LKuemmel
approved these changes
Sep 28, 2022
yankee42
force-pushed
the
refactor-inverter-module-call
branch
from
0e46b20 to
f5b4eae
Compare
…r-capable modules
yankee42
force-pushed
the
refactor-inverter-module-call
branch
from
f5b4eae to
c77b18d
Compare
yankee42
force-pushed
the
refactor-inverter-module-call
branch
from
c77b18d to
a334643
Compare
|
Auf den aktuellen master rebased und den Konflikt mit 268b594 gelöst (hier wurde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dieser PR ist das Äquivalent zu #1818 nur für Wechselrichter statt SoC.
Damit könnten eine Reihe der wr2_* Module überflüssig werden. Den Anfang in diesem PR mache ich mit dem wr2_json-Modul. Da ich nur eine PV habe konnte ich das jedoch noch nicht live testen.
Außerdem erfolgt der Modulaufruf von WR1 und WR2 nun in einer Schleife, damit beide Module auch wirklich möglichst exakt gleich behandelt werden und die Gefahr eliminiert wird, dass jemand etwas an einer der Positionen, aber nicht an der anderen Position ändert.