Enhancements and New Features #32
Conversation
GustavoBitten
commented
Aug 2, 2024
•
GustavoBitten
commented
- New Logic for Divided Laps: Added functionality to record and save half laps, providing more detailed tracking of progress.
- Improved Lap Saving Logic: Refined the process of saving laps, making it clearer and more intuitive.
- New Graph Tool: Able to scroll and drag better
|
Thanks for your contribution. I will look into it! |
There was a problem hiding this comment.
This file look wrong, please delete
| @@ -208,13 +225,15 @@ def update_speed_velocity_graph(laps: List[Lap]): | |||
| # Update breakpoints | |||
| # Adding Brake Points is slow when rendering, this is on Bokehs side about 3s | |||
| brake_points_enabled = os.environ.get("GT7_ADD_BRAKEPOINTS") == "true" | |||
| brake_points_enabled = True | |||
There was a problem hiding this comment.
Please don't overwrite the outcome of the environment variable
| import os | ||
| import time | ||
| import unittest | ||
|
|
||
| from gt7dashboard import gt7communication | ||
| from gt7dashboard.gt7lap import Lap | ||
|
|
||
| PLAYSTATION_IP = "ps5wifi" | ||
| PLAYSTATION_IP = "192.168.15.96" |
There was a problem hiding this comment.
Maybe we should find a solution that works for both of us. In the mean time, please do not change the IP.
| @@ -0,0 +1,140 @@ | |||
| from datetime import timedelta | |||
There was a problem hiding this comment.
I expect this is just reorganised to a different file?
| @@ -220,8 +223,11 @@ def __init__(self, width=400): | |||
| width=width, | |||
| height=250, | |||
| tooltips=tooltips, | |||
| active_drag="box_zoom", | |||
| active_drag="auto" | |||
There was a problem hiding this comment.
What does this change in behaviour?
|
|
||
|
|
||
|
|
||
| def divide_laps(old_data: GTData, new_data: GTData): |
There was a problem hiding this comment.
What does this do? I do not understand the whole logic behind device_laps and equalizer_lap. Please describe in the comment of the functions. Can you give a screenshot or something?
