SNOW-870432: use_logical_type for inferring timezone in pandas df #1134
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sfan
reviewed
Nov 9, 2023
| @@ -1478,6 +1479,41 @@ def test_create_dataframe_with_semi_structured_data_types(session): | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(not is_pandas_available, reason="pandas is required") | |||
| def test_create_dataframe_with_pandas_df(session): | |||
There was a problem hiding this comment.
Do we need to port some changes to sp connector too to support use_logical_type in stored proc?
There was a problem hiding this comment.
That's right. We need to port this to sproc too
There was a problem hiding this comment.
sfc-gh-sfan
reviewed
Nov 10, 2023
src/snowflake/snowpark/session.py
Outdated
| @@ -2008,6 +2014,7 @@ def create_dataframe( | |||
| quote_identifiers=True, | |||
| auto_create_table=True, | |||
| table_type="temporary", | |||
| use_logical_type=True, | |||
There was a problem hiding this comment.
Is this a behavior change (i.e. wrong behavior -> correct behavior)? Should we highlight the implication in change log?
There was a problem hiding this comment.
I'll update the changelog detailing what exactly is going to change
sfc-gh-sfan
approved these changes
Nov 11, 2023
…timestamp-correctly
…timestamp-correctly
…timestamp-correctly
…timestamp-correctly
sfc-gh-aling
approved these changes
Jan 2, 2024
sfc-gh-yixie
reviewed
Jan 2, 2024
CHANGELOG.md
Outdated
Comment on lines
18
to
19
| - Earlier timestamp columns without a timezone would be inferred as `LongType()` but will now be correctly inferred as `TimestampType(TimestampTimeZone.NTZ)`. | ||
| - Earlier timestamp columns without a timezone would be converted to nanosecond epochs, but will now be correctly be maintained as timestamp values. |
There was a problem hiding this comment.
Are these two lines for the same logic branch? If so please consider merging them.
There was a problem hiding this comment.
sure. I'll merge them
sfc-gh-yixie
approved these changes
Jan 3, 2024
sfc-gh-aalam
deleted the
aalam-SNOW-870432-use-logical-type-to-infer-timestamp-correctly
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #870432, SNOW-886649: write_pandas inserts datetime64[ns] to Snowflake as an Invalid Date #991
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Port the fix from snowflake python connector to use_logical_type when inferring datatype from parquet files.