Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1843885] Fix error caused by snowpark_round #2708

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sfc-gh-lspiegelberg
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1843885.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Fixes AST error caused by snowpark_round where due to aliasing session.ast_enabled was not properly propagated.

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg added bug Something isn't working NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Dec 3, 2024
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg changed the title [SNOW-1843885] Fix error causes by snowpark_round [SNOW-1843885] Fix error caused by snowpark_round Dec 3, 2024
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg marked this pull request as ready for review December 3, 2024 22:19
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg requested a review from a team as a code owner December 3, 2024 22:19
@sfc-gh-lspiegelberg
Copy link
Contributor Author

Waiting for https://github.com/snowflakedb/snowpark-python/actions/runs/12149211306 to pass to confirm fix for daily pandas runner.

@sfc-gh-azhan
Copy link
Collaborator

Waiting for https://github.com/snowflakedb/snowpark-python/actions/runs/12149211306 to pass to confirm fix for daily pandas runner.

You can try it locally and just rerun that test.

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg merged commit dc83b57 into main Dec 3, 2024
163 of 182 checks passed
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg deleted the ls-SNOW-1843885-bugfix branch December 3, 2024 23:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
@sfc-gh-lspiegelberg
Copy link
Contributor Author

Waiting for https://github.com/snowflakedb/snowpark-python/actions/runs/12149211306 to pass to confirm fix for daily pandas runner.

You can try it locally and just rerun that test.

Already did that before submitting a PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants