Mobile: Update to flutter 3.22.3 and packages #964
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request includes updates to various files in the Changes
Possibly related PRs
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ssandino
changed the title
KarinBerg
requested review from
ssandino,
andrashee,
mkue,
novas1r1 and
MDikkii
as code owners
|
Visit the preview URL for this PR (updated for commit 9ba3150): https://si-admin-staging--pr964-karin-update-to-flut-p9l4veaz.web.app (expires Sat, 14 Dec 2024 17:07:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
recipients_app/clean_build.sh (1)
15-22: Enhance version extraction robustnessThe version extraction logic could be more resilient to file format changes.
Consider this more robust implementation:
-REQUIRED_VERSION=$(grep flutter .tool-versions | awk '{print $2}') +REQUIRED_VERSION=$(grep "^flutter" .tool-versions | awk '{print $2}' || echo "") +if [ -z "$REQUIRED_VERSION" ]; then + echo "Error: Could not determine required Flutter version from .tool-versions" + exit 1 +firecipients_app/README.md (2)
8-8: Add explicit version informationWhile referencing .tool-versions is good for maintenance, adding the current version number in parentheses would improve clarity.
-Flutter (Version see file .tool-versions) +Flutter (Version see file .tool-versions, currently 3.22.3)
Line range hint
15-40: Add environment verification stepsThe Java and Flutter setup instructions would benefit from verification steps.
Add these verification commands after the setup instructions:
# Verify Java setup java -version # Should show version 17 echo $JAVA_HOME # Should point to Java 17 installation # Verify Flutter setup flutter doctor -v # Should show all checkmarks flutter config --jdk-dir # Should show the correct Java 17 path
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
recipients_app/pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
recipients_app/.tool-versions(1 hunks)recipients_app/README.md(1 hunks)recipients_app/clean_build.sh(2 hunks)recipients_app/lib/kri_intl.dart(4 hunks)recipients_app/lib/ui/buttons/button_outlined_big.dart(1 hunks)recipients_app/lib/ui/buttons/button_small.dart(2 hunks)recipients_app/lib/ui/configs/app_theme.dart(0 hunks)recipients_app/pubspec.yaml(1 hunks)
💤 Files with no reviewable changes (1)
- recipients_app/lib/ui/configs/app_theme.dart
✅ Files skipped from review due to trivial changes (1)
- recipients_app/.tool-versions
🔇 Additional comments (8)
recipients_app/lib/ui/buttons/button_outlined_big.dart (1)
24-25: LGTM: API migration for Flutter 3.22.3
The change from MaterialStateProperty to WidgetStateProperty is correct and aligns with Flutter's API updates.
recipients_app/pubspec.yaml (2)
8-9: Verify Dart SDK compatibility
The Dart SDK requirement has been increased to >=3.4.4. Ensure all team members have updated their development environment.
✅ Verification successful
SDK version 3.4.4 appears compatible with the codebase
The codebase scan shows only standard switch statements and no usage of newer Dart features like record classes, extension types, or pattern matching that would require Dart SDK 3.4.4 or higher.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if any Dart files use features not available in 3.4.4
rg -l 'record\s+class|extension\s+type|switch\s+expression'
Length of output: 61
Script:
#!/bin/bash
# Let's check for Dart files in the repository first
fd -e dart
# Then let's look for pattern matches that might indicate newer Dart features
rg -l 'sealed\s+class|base\s+class|interface\s+class|final\s+class|mixin\s+class|inline\s+class|\bswitch\s*\('
# Also check for pattern matches in imports that might indicate usage of newer SDK features
rg -l 'dart:.*\s+show.*Record\b|dart:.*\s+show.*Pattern\b'
Length of output: 8073
14-39: Verify package compatibility
Several packages have been updated. Notable changes:
- firebase_core: ^2.32.0
- intl: ^0.19.0
- sentry_flutter: ^8.10.1
✅ Verification successful
Package updates appear safe to proceed
The codebase uses standard APIs from Firebase Core, Intl, and Sentry packages. No deprecated patterns were found, and the usage is straightforward without any complex customizations that might be affected by the updates.
- Firebase Core is only used for basic app initialization
- Intl usage is limited to standard date formatting and phone number input
- Sentry implementation follows the standard integration pattern
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any deprecated API usage in the codebase
rg -l 'deprecated|@deprecated'
# Check changelog files for breaking changes
fd -e md -e txt -g "*change*" -x cat {}
Length of output: 119
Script:
#!/bin/bash
# Check for specific Firebase Core usage patterns that might be affected by the update
rg -p "firebase.*core" -g "!*.lock" -g "!*.yaml"
# Check for Intl usage patterns that might be affected by the update
rg -p "import.*intl" -g "!*.lock" -g "!*.yaml"
# Check for Sentry usage patterns that might be affected by the update
rg -p "import.*sentry" -g "!*.lock" -g "!*.yaml"
# Look for any Firebase initialization code
ast-grep --pattern 'Firebase.initializeApp($$$)'
Length of output: 1806
recipients_app/lib/ui/buttons/button_small.dart (1)
33-35: LGTM: Consistent API migration
The MaterialStateProperty to WidgetStateProperty migration is correctly applied for both outlined and filled button variants.
Also applies to: 58-60
recipients_app/lib/kri_intl.dart (4)
416-416: LGTM: Simplified delegate declaration
The delegate declaration has been simplified to a single line, which improves readability.
461-461: LGTM: Added required date picker order method
Added the required datePickerDateTimeOrder method to support the new Flutter version's date picker functionality.
665-665: LGTM: Simplified delegate declaration
The delegate declaration has been simplified to a single line, consistent with the change in the Cupertino localizations.
1134-1139: LGTM: Added required localization methods
Added new required methods clearButtonTooltip and selectedDateLabel to support the new Flutter version's functionality.
…S build error with the message "Cannot find type 'PhoneNumberKit' in scope". v0.8.0 is not publish on pub.dev but it is released on Github.
KarinBerg
deleted the
karin/update-to-flutter-3.22.3-and-update-packages
branch
Upgrade Flutter and its packages to the latest possible without changing the minimal supported versions of iOS and Android.
Summary by CodeRabbit
Release Notes
New Features
Improvements
Bug Fixes
Dependencies