-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile App] 989: Update Flutter SDK and packages, Xcode, Android Gradle #991
base: main
Are you sure you want to change the base?
[Mobile App] 989: Update Flutter SDK and packages, Xcode, Android Gradle #991
Conversation
KarinBerg
commented
Dec 20, 2024
- Update to latest Flutter SDK
- Use latest Xcode 16.2
- Upgrade Android Gradle to be compatible to Android Studio LadyBug with Java JDK 21 instead of JDK17
- Update Flutter Firebase packages => This leads to new minimum supported operating system versions.
- New Android min version of 23 instead of 21
- New iOS min version of iOS 13 instead of iOS 12
- Update all other possible Flutter packages
- Update Android minimum version from 21 to 23 - Update iOS minimum version from iOS 12 to iOS 13
…h Java JDK 21 instead of JDK17
Try rewriting the code to not use the 'BuildContext', or guard the use with a 'mounted' check.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
sourceSets { | ||
main.java.srcDirs += 'src/main/kotlin' | ||
} | ||
|
||
defaultConfig { | ||
applicationId "org.socialincome.app" | ||
minSdkVersion 21 | ||
minSdkVersion 23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minSdkVersion is because of Flutter Firebase packages update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file is a remaining from an older change where the app name was changed. In my opinion it is not needed anymore.
@@ -425,7 +425,7 @@ | |||
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
GCC_WARN_UNUSED_FUNCTION = YES; | |||
GCC_WARN_UNUSED_VARIABLE = YES; | |||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | |||
IPHONEOS_DEPLOYMENT_TARGET = 13.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPHONEOS_DEPLOYMENT_TARGET is because of Flutter Firebase packages update
@@ -1,5 +1,5 @@ | |||
# Uncomment this line to define a global platform for your project | |||
platform :ios, '12.0' | |||
platform :ios, '13.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of Flutter Firebase packages update
@@ -30,7 +30,7 @@ flutter_ios_podfile_setup | |||
target 'Runner' do | |||
use_frameworks! | |||
use_modular_headers! | |||
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '10.25.0' | |||
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '11.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of Flutter Firebase packages update
@@ -54,7 +54,7 @@ | |||
<key>LSRequiresIPhoneOS</key> | |||
<true/> | |||
<key>MinimumOSVersion</key> | |||
<string>12.0</string> | |||
<string>13.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of Flutter Firebase packages update
@@ -1,7 +1,7 @@ | |||
import UIKit | |||
import Flutter | |||
|
|||
@UIApplicationMain | |||
@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of Flutter update to version 3.17.1
@@ -54,7 +54,7 @@ abstract class AppTheme { | |||
elevatedButtonTheme: ElevatedButtonThemeData( | |||
style: ElevatedButton.styleFrom( | |||
foregroundColor: Colors.white, | |||
disabledBackgroundColor: AppColors.primaryColor.withOpacity(0.5), | |||
disabledBackgroundColor: AppColors.primaryColor.withValues(alpha: 0.5), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of Flutter update to version 3.17.1
@@ -45,7 +45,7 @@ class _InputDropdownState<T> extends State<InputDropdown<T>> { | |||
contentPadding: AppSpacings.h12v16, | |||
label: Text(widget.label), | |||
labelStyle: AppStyles.inputHint.copyWith( | |||
color: AppColors.darkGrey.withOpacity(0.6), | |||
color: AppColors.darkGrey.withValues(alpha: 0.6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of Flutter update to version 3.17.1
@@ -62,7 +62,7 @@ class InputText extends StatelessWidget { | |||
child: Text( | |||
hintText!, | |||
style: AppStyles.inputHint.copyWith( | |||
color: AppColors.darkGrey.withOpacity(0.6), | |||
color: AppColors.darkGrey.withValues(alpha: 0.6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of Flutter update to version 3.17.1
@@ -410,7 +411,8 @@ class KriCupertinoLocalizations extends GlobalCupertinoLocalizations { | |||
required super.singleDigitHourFormat, | |||
required super.singleDigitMinuteFormat, | |||
required super.doubleDigitMinuteFormat, | |||
required super.singleDigitSecondFormat, | |||
required super.singleDigitSecondFormat, | |||
required super.weekdayFormat, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of Flutter update to version 3.17.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do not need this file anymore. Please verify that!