Devalue parser #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrachequesne don't wanna bother, just wanna know if you have seen this PR? Also, if all is good, what is the process to get this in a package registry? |
|
Here we go! https://www.npmjs.com/package/@socket.io/devalue-parser Thanks a lot for your work on this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transforms this repo (fork of default parser) from a
JSON.stringify/JSON.parse-based parser to one usingdevalue. Support for binary data is kept as-is - only non-binary data is encoded/decoded withdevalue.As
devalueis ESM-only, this parser also needs to be ESM-only, removing the CJS build.Devalue offers many improvements over the standard (vanilla) JSON encoding, such as:
undefined, regular expressions, maps and sets (these are completely lost when using JSON),See all here.