Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macro_san v3 compatibility and ssh close #974

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zhilong-xu
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #974 (c293f22) into master (f2765e1) will decrease coverage by 0.05%.
The diff coverage is 42.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   70.83%   70.79%   -0.05%     
==========================================
  Files         195      195              
  Lines       23987    24048      +61     
  Branches     3674     3683       +9     
==========================================
+ Hits        16991    17024      +33     
- Misses       5831     5858      +27     
- Partials     1165     1166       +1     
Impacted Files Coverage Δ
delfin/drivers/macro_san/ms/macro_ssh_client.py 16.17% <0.00%> (-0.25%) ⬇️
delfin/drivers/macro_san/ms/ms_handler.py 63.02% <40.31%> (-1.57%) ⬇️
delfin/drivers/macro_san/ms/consts.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants