优化关联应用功能 #61
Open
优化关联应用功能 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ashlee618, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
优化关联应用功能以前的版本存在可以重复关联的bug 并且可以关联在zk中不存在的应用 public boolean isRelatedByModuleAndApp(int mId, String appName) {
return arkDao.queryRelationByModuleIdAndAppName(mId, appName).size() > 0;
}这里用的并非是最优雅的解决办法，用的是最简单粗暴的，有待优化。 |
glmapper
reviewed
Jul 11, 2021
| return new Docket(DocumentationType.SWAGGER_2) | ||
| .useDefaultResponseMessages(false) | ||
| .apiInfo(apiInfo()) | ||
| .groupName("1.0版本") |
There was a problem hiding this comment.
不建议在代码中直接使用这种常量，同时也不建议使用中文
There was a problem hiding this comment.
好的，这个打算后面换成5个分类，application、arkmng、core、governance、web这样方便开发者对接。
| System.out.println(hostAndPort); | ||
| } | ||
| public static void main(String[] args) { | ||
| String id = uniqueId(new HostAndPort("192.168.0.104", "8.16.32.64", 38081)); |
There was a problem hiding this comment.
maybe we need delete sysout?
| * @param appName | ||
| * @return | ||
| */ | ||
| List<AppArkDO> queryRelationByModuleIdAndAppName(int mId,String appName); |
| @@ -70,4 +70,10 @@ | |||
| public static final String ZOOKEEPER_PREFIX = "zookeeper://"; | |||
| public static final String SOFA_PREFIX = "sofa://"; | |||
|
|
|||
| // API接口类 | |||
| public static final String API_ARK_TAGS = "Ark相关接口"; | |||
There was a problem hiding this comment.
是不是可以考虑使用一个枚举来描述下所有的接口类型，而不是在 常量类中定义
| <dependency> | ||
| <groupId>com.github.xiaoymin</groupId> | ||
| <artifactId>knife4j-spring-boot-starter</artifactId> | ||
| <version>2.0.7</version> |
There was a problem hiding this comment.
版本管理在主pom 的 dependentmanagement 中
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用knife4j实现接口可视化功能
选择knife4j的原因
后续问题