Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update SvgPackage to supported stable API's #2541

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat: update SvgPackage to supported stable API's #2541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions android/src/main/java/com/horcrux/svg/SvgPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import static com.horcrux.svg.RenderableViewManager.*;

import androidx.annotation.Nullable;
import com.facebook.react.TurboReactPackage;
import com.facebook.react.BaseReactPackage;
import com.facebook.react.ViewManagerOnDemandReactPackage;
import com.facebook.react.bridge.JavaScriptModule;
import com.facebook.react.bridge.ModuleSpec;
Expand All @@ -36,7 +36,7 @@
SvgViewModule.class,
RNSVGRenderableManager.class,
})
public class SvgPackage extends TurboReactPackage implements ViewManagerOnDemandReactPackage {
public class SvgPackage extends BaseReactPackage implements ViewManagerOnDemandReactPackage {

private @Nullable Map<String, ModuleSpec> mViewManagers;

Expand Down Expand Up @@ -369,7 +369,6 @@ public Map<String, ReactModuleInfo> getReactModuleInfos() {
moduleClass.getName(),
reactModule.canOverrideExistingModule(),
reactModule.needsEagerInit(),
reactModule.hasConstants(),
reactModule.isCxxModule(),
true));
}
Expand Down
Loading