Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: currentColor stale value #2573

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

boazarad88
Copy link
Contributor

Summary

This is another fix for issue #2566 that also resets the color on prepareForRecycle (in the same manner of this fix #2570). I also don't have a sandboxed reproduce, but was able to verify the fix on my company's code which I unfortunately can't share.

Compatibility

OS Implemented
iOS
MacOS

@boazarad88 boazarad88 changed the title fix: reset color on prepareForRecycle fix: currentColor stale value Dec 9, 2024
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@jakex7 jakex7 merged commit d497830 into software-mansion:main Dec 16, 2024
4 of 6 checks passed
@boazarad88 boazarad88 deleted the fix-stale-currentcolor branch December 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants