feat!: Svg intrinsic size, auto and custom shadow nodes for RNSVGSvg #2577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE / NEW ARCH ONLY
Implement intrinsic and
auto
value forwidth
andheight
onSvg
component based on the specification.A huge thanks to @janicduplessis for #1720 with a similar concept. However, it needed to be implemented slightly different for some edge cases and the
RNSVGImage
implementation, which requires being a yoga node.Test Plan
Example app -> Svg examples
Compatibility
Checklist
README.md