Fix linting issues in GitHub Actions

[albertodvp]

Hi :)

I'm testing the library with GHC912 and the haskell-actions one is already supporting that. In this PR I did some updates to the GHA build job, in particular:

1. I've substituted the hspec setup action with the haskell-actions one. Note: cabal update is done by default by the used action.

2. Replaced macOS-12 environment which is deprecated.

3. I've also run actionlint and addressed those issues. Here is the output of that tool:

.github/workflows/build.yml:121:9: shellcheck reported issue in this script: SC2046:warning:1:12: Quote this to prevent word splitting [shellcheck]
    |
121 |       - run: cabal exec $(cabal list-bin spec)
    |         ^~~~
.github/workflows/build.yml:136:15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
    |
136 |       - uses: actions/checkout@v3
    |               ^~~~~~~~~~~~~~~~~~~

---

I've prepared this during this event

[sol]

Hi 👋

I'm testing the library with GHC912 and the haskell-actions one is already supporting that.

I think hspec/setup-haskell also already supported GHC 9.12.1. What it did not support was recent versions of macOS, as GitHub dropped support for ghcup from the macOS runner images. I fixed this in hspec/setup-haskell@cd264c7.

1. I've substituted the hspec setup action with the haskell-actions one. Note: cabal update is done by default by the used action.

I'm not interested in this change at this point.

.github/workflows/build.yml:121:9: shellcheck reported issue in this script: SC2046:warning:1:12: Quote this to prevent word splitting [shellcheck]
    |
121 |       - run: cabal exec $(cabal list-bin spec)
    |         ^~~~
.github/workflows/build.yml:136:15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
    |
136 |       - uses: actions/checkout@v3
    |               ^~~~~~~~~~~~~~~~~~~

This looks good. Can you rebase on main?

[albertodvp]

Thanks for the review. Assuming I'm understanding correctly, I've:

• removed the haskell-actions/setup
• kept the linting suggestions
• (rebased)

Does it look good? If it does, I would to rename the PR to something like: Apply lint to GHA (I'm not doing that by myself to avoid confusion)

[sol]

This documents which versions have CI issues. For that reason I would like to keep these.

[sol]

Same here.

[sol]

Same here.

[sol]

👍

[sol]

👍

[sol]

Thanks for the review. Assuming I'm understanding correctly, I've:

• removed the haskell-actions/setup
• kept the linting suggestions
• (rebased)

Yes exactly 👍

I would to rename the PR to something like: Apply lint to GHA

Yes, please go ahead. But instead of using an acronym, please spell it out, also in the commit message.

[sol]

Thanks a lot for your contribution.