Feature download containers #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lart2150
force-pushed
the
feature/download-containers
branch
4 times, most recently
from
2c2c420 to
5f014ba
Compare
|
@DASPRiD this is ready to review when you have time. |
|
LGTM. Could you squash this into two commits though for the two respective features (container download and get-script execution)? I can't do a squash merge as that would make both features a single commit with dual-purpose. |
lart2150
force-pushed
the
feature/download-containers
branch
from
d15d2f5 to
5c729a4
Compare
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filemaker 19.3.2 added AuthenticatedStream that requires a cookie to download a container. The first request requires the bearer token and that returns a set cookie header. The second request requires the cookie from the first request. I thought about adding a cookie library but it's just the one cookie that we need.
https://support.claris.com/s/article/Claris-FileMaker-Server-19-3-2-Release-Notes?language=en_US