Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular clean commands, build commands, util for using workspace package in examples #1695

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Dec 19, 2024

This split the clean command to examples, packages, root - to more granularly clean up .vinxi/, .output/, node_modules/, dist/

Also, since the clean:root command removes the ./node_modules/ where rimraf is currently installed, I found it was better to use pnpx rimraf to always allow running the clean commands

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 47519b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "solid-start-docs" depends on the ignored package "solid-start-mdx", but "solid-start-docs" is not being ignored. Please add "solid-start-docs" to the `ignore` option.

@birkskyum birkskyum changed the title More thorough clean:all More thorough clean:all, and pnpx rimraf Dec 19, 2024
@birkskyum birkskyum changed the title More thorough clean:all, and pnpx rimraf Better clean commands, util for using workspace package in examples Dec 19, 2024
@birkskyum birkskyum changed the title Better clean commands, util for using workspace package in examples Granular clean commands, build commands, util for using workspace package in examples Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants