Skip to content

Commit

Permalink
same wording for serviceOverrides
Browse files Browse the repository at this point in the history
  • Loading branch information
ashleywang1 committed Aug 30, 2024
1 parent 78f5943 commit c6224b1
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion codegen/cmd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ var _ = Describe("Cmd", func() {

painterNode := node.Content[0].Content[1]
enabledMapField := painterNode.Content[0]
Expect(enabledMapField.HeadComment).To(ContainSubstring("Arbitrary overrides for the component's [deployment spec template](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/), such as to set resource limits and requests. Format the overrides as YAML or JSON."))
Expect(enabledMapField.HeadComment).To(ContainSubstring("Arbitrary overrides for the component's [deployment spec"))
})

It("generates from templates using a name override", func() {
Expand Down
2 changes: 1 addition & 1 deletion codegen/model/values/helm_chart_values.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type UserValues struct {

// Overrides which can be set by the user
DeploymentOverrides *appsv1.Deployment `json:"deploymentOverrides" desc:"Arbitrary overrides for the component's [deployment spec template](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/), such as to set resource limits and requests. Format the overrides as YAML or JSON." omitChildren:"true"`
ServiceOverrides *v1.Service `json:"serviceOverrides" desc:"Arbitrary overrides for the component's [service template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/)." omitChildren:"true"`
ServiceOverrides *v1.Service `json:"serviceOverrides" desc:"Arbitrary overrides for the component's [service spec template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/)." omitChildren:"true"`
}

// document values structure for a container
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ weight: 2
|overrideName.resources|struct|Container resource requirements. For more info, see the [Kubernetes documentation](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#resourcerequirements-v1-core).| |
|overrideName.runAsUser|uint32|Static user ID to run the containers as. Unused if floatingUserId is 'true'.|10101|
|overrideName.securityContext|struct|Container security context. Set to 'false' to omit the security context entirely. For more info, see the [Kubernetes documentation](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#securitycontext-v1-core).| |
|overrideName.serviceOverrides|struct|Arbitrary overrides for the component's [service template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/).| |
|overrideName.serviceOverrides|struct|Arbitrary overrides for the component's [service spec template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/).| |
|overrideName.serviceType|string|Kubernetes service type. Can be either "ClusterIP", "NodePort", "LoadBalancer", or "ExternalName".| |
|overrideName.sidecars|map[string, struct]|Optional configuration for the deployed containers.|{}|
|overrideName.sidecars.<MAP_KEY>|struct|Optional configuration for the deployed containers.| |
Expand Down
2 changes: 1 addition & 1 deletion codegen/test/name_override_chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ overrideName:
ports: {}
# Static user ID to run the containers as. Unused if floatingUserId is 'true'.
runAsUser: 10101
# Arbitrary overrides for the component's [service
# Arbitrary overrides for the component's [service spec
# template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/).
serviceOverrides: null
# Kubernetes service type. Can be either "ClusterIP", "NodePort", "LoadBalancer",
Expand Down

0 comments on commit c6224b1

Please sign in to comment.