Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove auto page calculation from table #324

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

sijav
Copy link
Collaborator

@sijav sijav commented Nov 11, 2024

Description

Issue No: 958

remove auto page calculation from table

To-Dos

  • Extract i18n strings via yarn i18n:extract
  • Check formatting via yarn format:check
  • Lint via yarn lint and yarn lint:tsc
  • Test via yarn test

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have a pager that says that we can show x elements, than all the x elements should be displayed. This is what I see on a small screen, where I can not see a single line, when it says 100 are displayed.
image

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-11-14.at.10.35.36.mov

Now I have 2 scroll bars. Can we put the pager at the end of the table?

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The lower number on the pager is wrong: it shows entries 1-100 not 0-100
image

@sijav sijav requested a review from aquamatthias November 20, 2024 02:45
@aquamatthias aquamatthias merged commit 4898cb8 into main Nov 20, 2024
4 checks passed
@aquamatthias aquamatthias deleted the sj/fix/958-inventory-tab-0-0-of-26 branch November 20, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants