Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch MatMul Substitution #1292

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

itai-berman
Copy link
Collaborator

@itai-berman itai-berman commented Dec 12, 2024

Pull Request Description:

Add substitution to support MatMul function & operator by doing Reshape->Split->2D MatMul->Stack->Reshape

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

graph: Graph we apply the substitution on.
matmul_node: MatMul node to substitute
Returns:
Graph after applying the substitution.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention is the substitution is inplace.

@yarden-yagil-sony yarden-yagil-sony self-requested a review December 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants