Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix switch comparison #1126

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Fix switch comparison #1126

merged 7 commits into from
Nov 5, 2024

Conversation

stschott
Copy link
Collaborator

@stschott stschott commented Nov 5, 2024

No description provided.

swissiety
swissiety approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swissiety
Copy link
Collaborator

hmm... MutableBlockStmtGraphTest.testRemoveMultipleTrapsWithDifferentExceptionTypes:1098 » IllegalArgument Invalid StmtGraph. A Trap is not created as a traps endStmt was not visited during the iteration of all Stmts.

@stschott
Copy link
Collaborator Author

stschott commented Nov 5, 2024

Flaky test? Locally the test case passes.

@stschott
Copy link
Collaborator Author

stschott commented Nov 5, 2024

The only method I changed is not even called when running the MutableBlockStmtGraphTest.testRemoveMultipleTrapsWithDifferentExceptionTypes test.

@stschott stschott merged commit 1cde415 into develop Nov 5, 2024
7 checks passed
@stschott stschott deleted the fix/switchComparison branch November 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissiety swissiety swissiety approved these changes

@JonasKlauke JonasKlauke Awaiting requested review from JonasKlauke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stschott @swissiety