[feature/#946] WebView에 사진 다운로드 기능 추가 #947
Open
+199
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
l2hyunwoo
force-pushed
the
feature/#946
branch
from
12e16a4 to
4e66166
Compare
chattymin
approved these changes
Oct 29, 2024
Comment on lines
+117
to
+123
| downloadManager.enqueue(request) | ||
| } else { | ||
| permissionRequestLauncher.launch(android.Manifest.permission.WRITE_EXTERNAL_STORAGE) | ||
| } | ||
| } |
There was a problem hiding this comment.
요거 특정 횟수(아마 3회) 이상 요청하면 더이상 팝업 안뜨는걸로 아는데 그거 관련 로직 추가하는건 어떨까요??
There was a problem hiding this comment.
이거 제 기기에서 테스트가 안되는데 ㅋㅋㅋ 어카죠..
l2hyunwoo
force-pushed
the
feature/#946
branch
from
4291d92 to
88063c5
Compare
Comment on lines
+66
to
+72
| private val permissionRequestLauncher = registerForActivityResult( | ||
| ActivityResultContracts.RequestPermission() | ||
| ) { isGranted -> | ||
| if (!isGranted) { | ||
| toast("권한을 받아오지 못했습니다.") | ||
| } | ||
| } |
There was a problem hiding this comment.
이 부분 홈에서 알림 권한 얻어올 때도 쓰던데 따로 분리할 수 있을까요?
Comment on lines
+93
to
+97
| binding.webView.setDownloadListener { url, userAgent, contentDisposition, mimetype, _ -> | ||
| if (ContextCompat.checkSelfPermission( | ||
| this, | ||
| android.Manifest.permission.WRITE_EXTERNAL_STORAGE | ||
| ) == android.content.pm.PackageManager.PERMISSION_GRANTED |
There was a problem hiding this comment.
요 부분 아래 함수들(~handle)과 달리 따로 함수화하지 않은 이유가 있으실까요?
l2hyunwoo
force-pushed
the
feature/#946
branch
2 times, most recently
from
e76e2a3 to
be3ca64
Compare
l2hyunwoo
force-pushed
the
feature/#946
branch
2 times, most recently
from
806a6d9 to
403552f
Compare
l2hyunwoo
force-pushed
the
feature/#946
branch
from
403552f to
f892428
Compare
l2hyunwoo
force-pushed
the
feature/#946
branch
from
f892428 to
848ff2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?