Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[PORT] Система обмена сообщениями в КПК"" #155

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

Vonsant
Copy link
Collaborator

@Vonsant Vonsant commented Dec 12, 2024

Reverts #154

Ничоси, если просто все откатывать и говорить, что виноваты не следы, то следы от этого не перестанут быть виноватыми в лагах.

Тем временем причина лагов:
image

Can't resolve "Robust.Shared.GameObjects.MetaDataComponent" on entity 264465!
  at System.Environment.get_StackTrace()
  at Robust.Shared.GameObjects.EntityManager.GetNetEntity(EntityUid uid, MetaDataComponent metadata) in /home/runner/work/space-station-14-next/space-station-14-next/RobustToolbox/Robust.Shared/GameObjects/EntityManager.Network.cs:line 186
  at Content.Shared._CorvaxNext.Footprints.Components.FootprintComponent.FootprintComponent_AutoNetworkSystem.OnGetState(EntityUid uid, FootprintComponent component, ComponentGetState& args) in /home/runner/work/space-station-14-next/space-station-14-next/Content.Shared/obj/Release/Robust.Shared.CompNetworkGenerator/Robust.Shared.CompNetworkGenerator.ComponentNetworkGenerator/FootprintComponent_CompNetwork.g.cs:line 31
  at Robust.Shared.GameObjects.EntityManager.GetComponentState(IEventBus eventBus, IComponent component, ICommonSession session, GameTick fromTick) in /home/runner/work/space-station-14-next/space-station-14-next/RobustToolbox/Robust.Shared/GameObjects/EntityManager.Components.cs:line 1456
  at Robust.Server.GameStates.PvsSystem.GetEntityState(ICommonSession player, EntityUid entityUid, GameTick fromTick, MetaDataComponent meta) in /home/runner/work/space-station-14-next/space-station-14-next/RobustToolbox/Robust.Server/GameStates/PvsSystem.GetStates.cs:line 52
  at Robust.Server.GameStates.PvsSystem.AddPvsChunk(PvsChunk chunk, Single distance, PvsSession session) in /home/runner/work/space-station-14-next/space-station-14-next/RobustToolbox/Robust.Server/GameStates/PvsSystem.ToSendSet.cs:line 62
  at Robust.Server.GameStates.PvsSystem.GetEntityStates(PvsSession session) in /home/runner/work/space-station-14-next/space-station-14-next/RobustToolbox/Robust.Server/GameStates/PvsSystem.cs:line 303
  at Robust.Server.GameStates.PvsSystem.SerializeSessionState(PvsSession data) in /home/runner/work/space-station-14-next/space-station-14-next/RobustToolbox/Robust.Server/GameStates/PvsSystem.Serialize.cs:line 59
  at Robust.Server.GameStates.PvsSystem.SerializeState(Int32 i) in /home/runner/work/space-station-14-next/space-station-14-next/RobustToolbox/Robust.Server/GameStates/PvsSystem.Serialize.cs:line 41
  at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2.<ForWorker>b__1(RangeWorker& currentWorker, Int64 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
  at System.Threading.Tasks.TaskReplicator.Replica.Execute()
  at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
  at System.Threading.ThreadPoolWorkQueue.Dispatch()
  at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
Sawmill=resolve

Выглядит как следы, воняет как следы и имеет компонент FootprintComponent

@github-actions github-actions bot added S: Untriaged size/XL S: Needs Review ПРу необходим ревью Changes: Sprites Changes: Localization Изменяет локализацию Changes: UI and removed size/XL labels Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

RSI Diff Bot; head commit 60272f7 merging into b72d322
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_CorvaxNext/Misc/program_icons.rsi

State Old New Status
nanochat Added

Resources/Textures/_CorvaxNext/Objects/Devices/cartridge.rsi

State Old New Status
cart-chat Added

Edit: diff updated after 60272f7

@AwareFoxy
Copy link
Collaborator

Жду ревью от Торнадо в любом случае

@Tornado-Technology
Copy link
Collaborator

Вы че по ахуевали блять

@Tornado-Technology Tornado-Technology merged commit 67e2d78 into master Dec 13, 2024
12 checks passed
@Tornado-Technology Tornado-Technology deleted the revert-154-revert-153-PDAChat branch December 13, 2024 07:51
@Tornado-Technology
Copy link
Collaborator

Ищите через графану

@Tornado-Technology
Copy link
Collaborator

А не рверты

@CaptainSqrBeard
Copy link

руми тигер офигеет когда увидит как много вы тут ревёртали :)

@Tornado-Technology
Copy link
Collaborator

руми тигер офигеет когда увидит как много вы тут ревёртали :)

Щас сделаю реверт реверта реверта реверта

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Изменяет локализацию Changes: Sprites Changes: UI S: Needs Review ПРу необходим ревью S: Untriaged size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants