Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added public Exp func #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added public Exp func #9

wants to merge 2 commits into from

Conversation

sudachen
Copy link
Contributor

@sudachen sudachen commented Jul 1, 2021

No description provided.

@sudachen sudachen requested a review from noamnelke July 1, 2021 12:44
noamnelke
noamnelke approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@noamnelke noamnelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment I have is that since this is now a public function, we should probably add tests for this specifically. If not trivial - at least let's create an issue to do so later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamnelke noamnelke noamnelke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudachen @noamnelke