[Merged by Bors] - v2alpha1: Implement v2alpha1 ActivationService.Highest rpc #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpersaw
requested review from
dshulyak,
fasmat,
poszu,
ivan4th,
acud and
jellonek
as code owners
fasmat
requested changes
Dec 18, 2024
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6552 +/- ##
=========================================
- Coverage 79.9% 79.8% -0.1%
=========================================
Files 354 354
Lines 46899 46918 +19
=========================================
- Hits 37484 37462 -22
- Misses 7298 7329 +31
- Partials 2117 2127 +10 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Dec 18, 2024
|
bors merge |
|
Build failed: |
|
bors merge |
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6539
This pull request introduces several significant changes to the
api/grpcserver/v2alpha1/activation.gofile, including the addition of a new interface, modifications to theActivationServicestruct, and the implementation of new methods. Additionally, it includes updates to the testing framework and dependencies. Below is a summary of the most important changes.Changes to
activation.go:activationProviderinterface with methodsGetAtxandMaxHeightAtx.NewActivationServicefunction to accept additional parametersatxProviderandgoldenAtx.Highestto theActivationServicestruct to return the highest ATX.Mock and Test Updates:
activationProviderinterface inactivation_mocks.go.activation_test.goto use the newactivationProvidermock and added a new test for theHighestmethod. [1] [2] [3] [4] [5]