Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - v2alpha1: Implement v2alpha1 ActivationService.Highest rpc #6552

Closed
wants to merge 3 commits into from

Conversation

kacpersaw
Copy link
Contributor

Description

Closes #6539

This pull request introduces several significant changes to the api/grpcserver/v2alpha1/activation.go file, including the addition of a new interface, modifications to the ActivationService struct, and the implementation of new methods. Additionally, it includes updates to the testing framework and dependencies. Below is a summary of the most important changes.

Changes to activation.go:

  • Added a new activationProvider interface with methods GetAtx and MaxHeightAtx.
  • Modified the NewActivationService function to accept additional parameters atxProvider and goldenAtx.
  • Added a new method Highest to the ActivationService struct to return the highest ATX.

Mock and Test Updates:

  • Generated a mock for the activationProvider interface in activation_mocks.go.
  • Updated tests in activation_test.go to use the new activationProvider mock and added a new test for the Highest method. [1] [2] [3] [4] [5]

node/node.go Outdated Show resolved Hide resolved
api/grpcserver/v2alpha1/activation.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.8%. Comparing base (471889f) to head (34a2545).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/grpcserver/v2alpha1/activation.go 85.7% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6552     +/-   ##
=========================================
- Coverage     79.9%   79.8%   -0.1%     
=========================================
  Files          354     354             
  Lines        46899   46918     +19     
=========================================
- Hits         37484   37462     -22     
- Misses        7298    7329     +31     
- Partials      2117    2127     +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kacpersaw
Copy link
Contributor Author

bors merge

@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member

fasmat commented Dec 19, 2024

bors merge

@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title v2alpha1: Implement v2alpha1 ActivationService.Highest rpc [Merged by Bors] - v2alpha1: Implement v2alpha1 ActivationService.Highest rpc Dec 19, 2024
@spacemesh-bors spacemesh-bors bot closed this Dec 19, 2024
@spacemesh-bors spacemesh-bors bot deleted the v2alpha1-highest branch December 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2alpha1: Add Highest rpc to Activation service
2 participants