[Merged by Bors] - Use go version specified by go.mod for CI #6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
dshulyak,
poszu,
ivan4th,
acud and
jellonek
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #6560 +/- ##
=========================================
- Coverage 79.8% 79.7% -0.1%
=========================================
Files 355 355
Lines 47143 47143
=========================================
- Hits 37635 37618 -17
- Misses 7371 7386 +15
- Partials 2137 2139 +2 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Dec 20, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
## Motivation The CI still uses a hard coded go version to build and unit test the node code. Both the release and systest jobs already parse and use the version specified in `go.mod`. This updates the CI to also use the version in `go.mod` instead of a hard coded setting.
ivan4th
approved these changes
Dec 20, 2024
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
## Motivation The CI still uses a hard coded go version to build and unit test the node code. Both the release and systest jobs already parse and use the version specified in `go.mod`. This updates the CI to also use the version in `go.mod` instead of a hard coded setting.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The CI still uses a hard coded go version to build and unit test the node code. Both the release and systest jobs already parse and use the version specified in
go.mod. This updates the CI to also use the version ingo.modinstead of a hard coded setting.Description
When setting up go on the runner use the version specified in
go.modfor build and unit test jobs instead of a hard coded version.Test Plan
existing tests pass
TODO