Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure server is started before handling requests #6570

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Dec 23, 2024

Motivation

Fixes #6113. Ensures that when the p2p servier is started requests aren't handled before protocols are available.

Description

Before doing anything in the p2p.Server.Run method ensure that the muxer has at least one protocol available.

Test Plan

  • without this fix Test_GetAtxsLimiting fails in about 2% of all test runs on my machine. With this change 500 runs of the test passed without an error.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.8%. Comparing base (bfcd746) to head (8f4496b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #6570   +/-   ##
=======================================
  Coverage     79.7%   79.8%           
=======================================
  Files          355     355           
  Lines        47168   47179   +11     
=======================================
+ Hits         37615   37663   +48     
+ Misses        7408    7371   -37     
  Partials      2145    2145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivan4th
Copy link
Contributor

ivan4th commented Dec 26, 2024

See #6573 which fixes the underlying problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test_GetAtxsLimiting
2 participants