-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify address button to Receive modal #83
Conversation
You can preview the changes at : https://e1239a33.smapp-lite-prod.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the address check is rejected on the ledger, it gets automatically the modal claiming (incorrectly) the ledger is disconnected.
also the error messages were a bit messy🤔
Screen.Recording.2024-09-10.at.16.22.51.mov
d74b3cc
to
477d993
Compare
You can preview the changes at : https://df41b117.smapp-lite-prod.pages.dev |
477d993
to
3eb2192
Compare
You can preview the changes at : https://0fcd607e.smapp-lite-prod.pages.dev |
@monikasmolarek thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brusherru This is indeed fixed, thanks !
but please double-check the case when you start the address verification, you don't do anything on the ledger, so the request there is waiting for your approve/reject, but in the Wallet you click OK or close the modal etc.
When the tx/action is pending on the device, the Wallet gets really confused about the device connection.
Screen.Recording.2024-09-12.at.00.55.34.mov
My steps in this rec:
- opened receive, clicked verify -> checked the device but didn’t approve or reject, left pending
- clicked OK on the modal
- opened receive, clicked verify again-> the reconnect modal appeared
- took device, approved the request -> it got approved "in the background" below the reconnect modal
- the wallet got confused about the connection
You can preview the changes at : https://96c11141.smapp-lite-prod.pages.dev |
Ok, I'm pretty sure it is fine, so I'm merging it. |
It is requested by Ledger company to add a "verify" button on "Receive" modal, that asks User to verify the address on his Ledger device. So now it is implemented.
It may require design improvement or rephrasing.
And there is also possible another case with red text, saying: "The address is incorrect, probably you are using another Ledger device." :)